agama-project / agama / 12810406017

73%

Build Type

push

github

Committed by web-flow

Commit Message

fix: display error messages during installation (#1909)

## Problem

If something goes wrong during packages installation, Agama web UI does
not show any message. We
found out that there are some problems:

- When the connection goes down, TanStack Query will not perform any
request (until the network is
  up).
- The UI might loose the `QuestionsChanged` event if it is reconnecting
the WebSocket at that point.

## Solution

To overcome those problems, we have introduced the following changes:

- Set TanStack Query [network
mode](https://tanstack.com/query/v5/docs/framework/react/guides/network-mode)
to "always" when running on localhost.
- Invalidate `questions` query when the WebSocket is reconnected to make
sure we do not miss any
  message.

> [!NOTE]
> We could play with the `refetchOnReconnect` setting at global level.
But let's be conservative at
> this point.

## Additional changes

`agama-web-server`:

- Exit the WebSocket handler when the client is disconnected
- Log the events

`web UI`:

- **refactor(web): expose onerror and onclose at WSClient level**

## Testing

- _Tested manually_

## Screenshots

![Error message from
libzypp](https://github.com/user-attachments/assets/66808bc4-0b0d-4b3d-b64d-7d642ba9af9e)

Run Details

0 of 3 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

17174 of 24202 relevant lines covered (70.96%)

35.57 hits per line