12721284583
83%

Ran 11 Jan 2025 05:42AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 10 Jan 2025 10:21PM UTC coverage: 85.604% (+0.09%) from 85.512%

Build # 12721284583

Build Type

push

github

Committed by

web-flow

Commit Message

Test: expected a fully formed cluster error (#6364)

Cluster tests would sometimes fail with the following error message:
```
jetstream_helpers_test.go:774: Expected a fully formed cluster, only 0 of 3 peers seen
```

This was due to a logic error in the tests, where it was assumed that
once a meta leader is chosen it will remain the same. That's not always
true as the meta leader can still shift around. So, keep fetching the
latest leader and check the peers on that.

Previously it would fail by selecting a meta leader, the meta leader
would change, and the follower would then be used to request peers on.
But because of the following lines in `JetStreamClusterPeers()`:
```go
	cc := js.cluster
	if !cc.isLeader() || cc.meta == nil {
		return nil
	}
```
You'd get no peers at all, leading into that error message.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

68667 of 80215 relevant lines covered (85.6%)

1101997.73 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	83.06	-0.09%	src/github.com/nats-io/nats-server/server/jetstream.go
2	86.21	-0.05%	src/github.com/nats-io/nats-server/server/events.go
3	86.17	-0.09%	src/github.com/nats-io/nats-server/server/accounts.go
4	52.47	0.24%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
4	94.54	-0.13%	src/github.com/nats-io/nats-server/server/server.go
6	80.66	-0.13%	src/github.com/nats-io/nats-server/server/opts.go
7	85.17	-0.04%	src/github.com/nats-io/nats-server/server/stream.go
8	84.94	0.3%	src/github.com/nats-io/nats-server/server/raft.go
12	83.94	-0.1%	src/github.com/nats-io/nats-server/server/filestore.go
14	85.58	0.53%	src/github.com/nats-io/nats-server/server/memstore.go
14	73.33	-0.26%	src/github.com/nats-io/nats-server/server/jetstream_api.go
329	88.09	-0.23%	src/github.com/nats-io/nats-server/server/consumer.go
1129	81.83	1.09%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	12721284583.1	11 Jan 2025 05:42AM UTC	57	85.6	GitHub Action Run

nats-io / nats-server / 12721284583
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12721284583

nats-io / nats-server / 12721284583 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12721284583

nats-io / nats-server / 12721284583
83%

README BADGES
x