hathitrust / otis / 12699703082

98%

push

github

Remove unnecessary query to try to speed up ht_users index page. (#243)

* Remove unnecessary query to try to speed up ht_users index page.
- `@all_users` was being populated via SQL in all cases even though it was only used for CSV download.
- The query has been removed and the CSV now uses the active + inactive arrays so the query was redundant anyway.
* - (Controller) `HTUser.includes` changed from `HTUser.joins` to pick up the approval requests without having to make a query for each.
- `HTApprovalRequest.most_recent_order` made public so the correct request can be selected by the presenter.
- `HTUser#ht_approval_request` uses `most_recent_order` by default for cases (if any) not covered by the controller change.

9 of 9 new or added lines in 4 files covered. (100.0%)

3194 of 3271 relevant lines covered (97.65%)

104.48 hits per line