djeedai / bevy_hanabi / 12677561640

66%

Build Type

push

github

Committed by web-flow

Commit Message

Split properties into new `PropertyCache` (#413)

Split the properties from the `EffectCache` and move their resource
management into a new `PropertyCache`, which allocates GPU buffers to
store them. This clarifies ownership, and allows better batching (in
theory) as not all effects use properties.

In this change, unfortunately for simplicity we directly store the
offset into the property buffer for each instance into the effect batch,
meaning we again block batching multiple effects. This is hopefully
temporary (and not the only blocker, so doesn't introduce any
regression), but makes the change incremental and easier to handle for
now, while other clean-ups are still pending.

Run Details

98 of 602 new or added lines in 8 files covered. (16.28%)

34 existing lines in 2 files now uncovered.

3171 of 6757 relevant lines covered (46.93%)

20.52 hits per line