MITLibraries / dspace-submission-composer / 12677602835

96%

Build Type

push

github

Committed by web-flow

Commit Message

In 1103 reconcile cli command (#56)

* Refactor BaseWorkflow class and add CLI options

* Refactor BaseWorkflow to move init args to class attributes
* Add load and get_workflow class methods to BaseWorkflow class
* Add metadata_mapping property to BaseWorkflow class
* Add click options to main CLI command
* Add load method call and other basic functionality to main CLI command
* Add post_main_group_subcommand to cli.py
* Add TestBaseWorkflow class and TestSimpleCSV class to conftest.py

* Add reconcile CLI command

Why these changes are being introduced:
* A CLI command is needed to reconcile metadata against files in the specified S3 batch path.

How this addresses that need:
* Add reconcile CLI command and corresponding CLI tests
* Add build_bitstream_dict, match_bitstreams_to_item_identifiers, and
match_item_identifiers_to_bitstreams functions as well as corresponding unit tests
* Add test_metadata_mapping.json to fixtures directory

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1128

* Update Pipfile.lock

* Updates based on discussion in #56

* Update formatting of click options
* Shift reconcile functionality to BaseWorkflow.reconcile_bitstreams_and_metadata method and add corresponding unit tests
* Add unit tests for BaseWorkflow's load and get_workflow methods
* Refactor get_workflow method to use subclasses
* Remove WORKFLOWS constant from config.py
* Add InvalidWorkflowNameError exception
* Replace setdefault call with defaultdict in build_bitstream_dict function
* Remove file type filtering from build_bitstream_dict function and remove related unit and CLI tests

* Updates based on further discussion in #56

* Shift build_bitstream_dict, match_bitstreams_to_item_identifiers, and match_item_identifiers_to_bitstreams to BaseWorkflow private methods

* More updates based on discussion in PR #56

* Rename reconcile-related variables for clar... (continued)

Run Details

75 of 76 new or added lines in 4 files covered. (98.68%)

1 existing line in 1 file now uncovered.

369 of 382 relevant lines covered (96.6%)

0.97 hits per line