MITLibraries / dspace-submission-composer / 12602522762

96%

push

github

Refactor SQS functionality and add new high-level methods (#33)

* Refactor SQS functionality and add new high-level methods

Why these changes are being introduced:
* The SQS functionality copied from wiley-deposits needs to be refactored to accommodate additional workflows.

How this addresses that need:
* Update ItemSubmission class to store item_identifier rather than metadata_s3_key as an attribute
* Update ItemSubmission.upload_dspace_metadata method signature to accept s3_prefix
* Add ItemSubmission.send_submission_message method and corresponding unit test
* Rename SQSClient.create_dss_message_attributes param package_id > identifier for clarity
* Update SQSClient.create_dss_message_body to handle multiple bitstreams
* Rename method to SQSClient.validate_result_message to clarify the type of SQS message being validated
* Update BaseWorkflow.s3_prefix type hinting
* Update BaseWorkflow.run method and corresponding unit test
* Refactor BaseWorkflow.item_submission_iter to account for the new ItemSubmission.item_identifier attribute
* Add s3 to metadata_uri and bitstream_uris attribute names across repo for clarity

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1128

* Updates based on discussion in PR #33

* Add links to DSS message spec in docstrings
* Update tests after SimpleCSV PR merge

* Further updates based on discussion in PR #33

* Rename identifier > item_identifier
* Rename s3_prefix > prefix

32 of 34 new or added lines in 4 files covered. (94.12%)

306 of 318 relevant lines covered (96.23%)

0.96 hits per line