rust-bitcoin / rust-bitcoin / 12626033211

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3855: io: Use get_ref / get_mut API

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/12a83e1bf3b7c8ef8ddfee028b62b2a74ee50585">12a83e1bf<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b0ec566742eba0680585aa1b9f1d910eb9f159ed"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/88dfd4e8f2b12f5e50caab16481c4e0a8935c9f7">88dfd4e8f</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b0ec566742eba0680585aa1b9f1d910eb9f159ed"> io: Use get_ref / get_mut API (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b7fdb359e76a2ec170d7b9abc704a7a29a0890c6">b7fdb359e</a> io: Move constructors (Tobin C. Harding)

Pull request description:

  Currently in the `bridge` module to get a reference and mutable reference we provide the `as_inner` and `inner_mut` functions. These names are not in line with the `std::io` module which favours `get_ref` and `get_mut`.

  Add inherent functions `get_ref` and `get_mut` for accessing the wrapped value in `bridge::ToStd` and deprecate `as_inner` and `inner_mut`.

  To convince yourself this API is correct grep the stdlib `io` module for `fn get_ref` as opposed to `fn as_ref`.

  Patch 1 is a trivial code move cleanup.

  Close: #3832

ACKs for top commit:
  apoelstra:
    ACK 12a83e1bf3b7c8ef8ddfee028b62b2a74ee50585; successfully ran local tests

Tree-SHA512: a5ebd806ad0d2fdb00a9cecf3cb8e39e6d4

0 of 5 new or added lines in 1 file covered. (0.0%)

20689 of 24937 relevant lines covered (82.97%)

17446.44 hits per line