rust-bitcoin / rust-bitcoin / 12623165367

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3854: Add parenthesis to explicitly show precedence

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2c9fda413572e251fe3fd07f679b6c786da137b3">2c9fda413 Add parenthesis to explicitly show precedence (Tobin C. Harding)

Pull request description:

  Recent clippy nightly update introduces warnings about precedence. While ours are, IMO, clear the lint docs have some cases that are not so I don't think we should ignore this lint. Specifically I could easily miss this one

    1 << 2 + 3 equals 32, while (1 << 2) + 3 equals 7

  ref: https://rust-lang.github.io/rust-clippy/master/#/precede

  Add parenthesis to explicitly show precedence. Refactor only no logic changes.

ACKs for top commit:
  apoelstra:
    ACK 2c9fda413572e251fe3fd07f679b6c786da137b3; successfully ran local tests; yeah, these all seem reasonable

Tree-SHA512: 67b8cb56c7bc230878b3904cf19b77a9db9

17 of 21 new or added lines in 3 files covered. (80.95%)

20689 of 24935 relevant lines covered (82.97%)

17390.26 hits per line