rust-bitcoin / rust-bitcoin / 12605742792

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3846: Remove `test_` prefix from unit tests

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/85e04315d5eb90075ce55bf18fab8876a4583def">85e04315d Remove test_ prefix from unit tests (Tobin C. Harding)

Pull request description:

  There is a loose convention in Rust to not use `test_` prefix. The reason being that `cargo test` outputs 'test <test name>' using the prefix makes the output stutter.

  This patch smells a bit like code-churn but having the prefix in some places and not others is confusing to new contributors and is leading me to explain this many times now. Lets just fix it.

  Remove the prefix unless doing so breaks the code.

ACKs for top commit:
  shinghim:
    ACK 85e04315d5eb90075ce55bf18fab8876a4583def
  apoelstra:
    ACK 85e04315d5eb90075ce55bf18fab8876a4583def; successfully ran local tests

Tree-SHA512: d90ae5ef7e660ba71ea5c73ebc3a414f14a

93 of 93 new or added lines in 21 files covered. (100.0%)

20439 of 24761 relevant lines covered (82.55%)

17542.42 hits per line