rust-bitcoin / rust-bitcoin / 12605411662

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3842: Remove usage of impl_from_infallible in leaf crates

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/0d8e9ef096fd60fcdb7928697c8f554bf428b754">0d8e9ef09 Remove usage of impl_from_infallible in leaf crates (Tobin C. Harding)

Pull request description:

  Rust macros, while at times useful, are a maintenance nightmare. And we have been bitten by calling macros from other crates multiple times in the past.

  In a push to just use less macros remove the usage of the `impl_from_infallible` macro in all the leaf crates and just write the code.

ACKs for top commit:
  apoelstra:
    ACK 0d8e9ef096fd60fcdb7928697c8f554bf428b754; successfully ran local tests; this is a great change

Tree-SHA512: c4cff451721d11ac14ed3ea5840b8bfb0b2

20439 of 24761 relevant lines covered (82.55%)

17574.45 hits per line