rust-bitcoin / rust-bitcoin / 12550265217

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3823: Improve Cursor ref API

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ae129d84ace03fba57bb980cace5aa60ff6bc10e">ae129d84a<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0ac5b4304010c7a41e7efd77df93aa8bf9499241"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3f433f1cde54f8be56ff20b5e4a7ff509de126b7">3f433f1cd</a> Improve Cursor ref API (Tobin C. Harding)

Pull request description:

  Our `Cursor` is a replacement of sorts for the `std::io::Cursor`. Users of the `Cursor` are likely to expect the same API so to get a reference and/or mutable reference users will likely reach for `get_ref` and `get_mut`. We should provide these.

  Deprecate `inner` since it is the same as `get_ref` but less idiomatically named (should have been `as_inner`).

  Add `get_ref` and `get_mut` methods to the `Cursor` type.

ACKs for top commit:
  apoelstra:
    ACK ae129d84ace03fba57bb980cace5aa60ff6bc10e; successfully ran local tests

Tree-SHA512: 664d08cc9570f50c51d28baed5449a7b765

Run Details

0 of 2 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

20418 of 24659 relevant lines covered (82.8%)

17681.07 hits per line