rust-bitcoin / rust-bitcoin / 12548223973

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3811: Introduce an unchecked constructor for the `Amount` type

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2042d91be59a1d47afb986cef0152f9b5250f476">2042d91be<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/13c066e195fcd2cea41ca1403791071c27a41810"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/04bae4bb914b1173d7c300174505a0c34592cab5">04bae4bb9</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/13c066e195fcd2cea41ca1403791071c27a41810"> Use _unchecked in unit tests (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8e6784dd417dfb06b985407a60f3aeea4ec99db9">8e6784dd4</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/13c066e195fcd2cea41ca1403791071c27a41810"> Introduce Amount::from_sat_unchecked (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f32af7dac6a3797b983cd200695d2ab3776bf736">f32af7dac</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/13c066e195fcd2cea41ca1403791071c27a41810"> Use ua_sat throughout test function (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/75f0afd0a3d8c9946cd3509a4388e0624a41e222">75f0afd0a</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/13c066e195fcd2cea41ca1403791071c27a41810"> Add local variable to use as constructor (Tobin C. Harding)
940a24413 Replace Amount::from_sat(0) with ZERO (Tobin C. Harding)

Pull request description:

  This is a small-ish changeset in order to mirror what was started in #3769 and reduce the diff in #3794

  - Patch 1: Trivial refactor to use `Amount::ZERO`.
  - Patch 2: Add the constructor and refactor a single unit test to use it.
  - Patch 3: Use the two `_unchecked` constructors throughout `units/src/amount/tests.rs`.
  - Patch 4: Add the API text file changes.

ACKs for top commit:
  jamillambert:
    ACK 2042d91be59a1d47afb986cef0152f9b5250f476
  apoelstra:
    ACK 2042d91be59a1d47afb986cef0152f9b5250f476; successfully ran local tests

Tree-SHA512: 8f9c3816582273457b778738f5542176cf5

71 of 71 new or added lines in 3 files covered. (100.0%)

20418 of 24657 relevant lines covered (82.81%)

17691.65 hits per line