kobotoolbox / kpi / 12438583128

81%

master: 76%

push

github

feat(organizations): update owner filtering on projects table TASK-1335 (#5362)

### 📣 Summary
Enable filtering by both the organization name and the owner's name when
selecting 'Owner' as a filter on the projects table.

## 💭 Notes 
Known issues (Olivier's notes from Notion task)

Because we are searching on both field at the same time (it would be too
difficult to do conditional search on whether the organization is MMO).
Returned results could be false positive.
Example: 
Tino sees two projects on in “My Project” list 

- Project 1 owns by olivierleger the user 
- Project 2 owns by jnm the user, but filled out the registration form
with “leger inc” as his the organization.

If Tino searches for “owner” which should contain “leger”, both projects
will appear, even if Project 2 shows “jnm” as the owner.

### 👀 Preview steps

Feature/no-change template:
1. ℹ️ have account (someuser) and several projects 
2. have user (kobouser) with organization name (Some Org) share a
project with your account
3. have user (anotheruser) who is part of an MMO (Kobo Inc) share a
project with your account
4. 🟡 notice that projects by **_someuser_** and **_kobouser_** have the
owner name as the owner label, but projects by **_anotheruser_** have
**_Kobo Inc_** as the owner label (not part of this pr but important)
5. ➡️  filter by "Owner" contains "user"
6. 🟢 notice that all projects are shown
7. ➡️  filter by "Owner" contains "kobo"
8. 🟢 notice that projects from **_kobouser_** and **_Kobo Inc_** are
shown
9. ➡️  filter by "Owner" contains "some"
10. 🟢 notice that projects from **_someuser_** and **_kobouser_** are
shown. (Even though **_kobouser_** is shown as the owner name, we are
filtering by the organization name as well, more on false positive in
Notes above).

---------

Co-authored-by: Olivier Leger <olivierleger@gmail.com>

5791 of 9278 branches covered (62.42%)

22160 of 27541 relevant lines covered (80.46%)

0.8 hits per line