12411663047
92%

Ran 19 Dec 2024 11:20AM UTC

Jobs 14

Files 231

Run time 1min

Badge

Embed ▾

Committed 19 Dec 2024 11:19AM UTC coverage: 87.968% (+0.003%) from 87.965%

Build # 12411663047

Build Type

push

github

Committed by

web-flow

Commit Message

[native_assets_builder] Use ` package:file`s `FileSystem` abstraction (#1825)

The main motivation for this change is to make `package:native_assets_builder` cleanly usable in flutter tools. Right now flutter tools operates on a `FileSystem` and checks whether `.dart_tool/package_config.json` exists using that `FileSystem` but then reads the file with this packagag's code which uses `dart:io`.

This inconsistency causes issues in flutter tools. Using `package:file` should solve this and would also
allow injecting mocks. To be fully mockable the implementation would also need to make process invocations
mockable via `package:process`. That's a future task.

See also https://github.com/dart-lang/native/issues/90

Run Details

59 of 62 new or added lines in 7 files covered. (95.16%)

12136 of 13796 relevant lines covered (87.97%)

34.0 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	90.24	0.0%	pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart
2	61.11	-2.05%	pkgs/native_assets_builder/lib/src/utils/file.dart

Subprojects

ID	Flag name	Job ID	Ran	Files	Coverage
6	native_assets_cli_ubuntu	12411663047.6	19 Dec 2024 11:21AM UTC	29	76.61	GitHub Action Run
7	native_toolchain_c_windows	12411663047.7	19 Dec 2024 11:23AM UTC	26	78.69	GitHub Action Run
8	native_assets_builder_ubuntu	12411663047.8	19 Dec 2024 11:24AM UTC	11	90.41	GitHub Action Run
9	native_assets_cli_windows	12411663047.9	19 Dec 2024 11:22AM UTC	29	76.28	GitHub Action Run
10	native_toolchain_c_ubuntu	12411663047.10	19 Dec 2024 11:21AM UTC	26	74.37	GitHub Action Run
11	native_assets_builder_macos	12411663047.11	19 Dec 2024 11:24AM UTC	11	90.41	GitHub Action Run
12	native_toolchain_c_macos	12411663047.12	19 Dec 2024 11:21AM UTC	26	69.6	GitHub Action Run
13	native_assets_cli_macos	12411663047.13	19 Dec 2024 11:20AM UTC	29	76.61	GitHub Action Run
14	native_assets_builder_windows	12411663047.14	19 Dec 2024 11:26AM UTC	11	90.41	GitHub Action Run
14	swift2objc	12362379980.14	16 Dec 2024 10:24PM UTC	40	87.07	GitHub Action Run
14	jni	12342848478.14	15 Dec 2024 10:38PM UTC	30	70.77	GitHub Action Run
13	jnigen	12342848478.13	15 Dec 2024 10:44PM UTC	22	89.31	GitHub Action Run
2	ffigen	11849122173.2	15 Nov 2024 02:35AM UTC	72	91.46	GitHub Action Run
14	objective_c	12388687570.14	18 Dec 2024 08:02AM UTC	73	78.19	GitHub Action Run

dart-lang / native / 12411663047
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Subprojects

Source Files on build 12411663047

dart-lang / native / 12411663047 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Subprojects

Source Files on build 12411663047

dart-lang / native / 12411663047
92%

README BADGES
x