12396681031
92%

Ran 18 Dec 2024 04:00PM UTC

Jobs 14

Files 231

Run time 1min

Badge

Embed ▾

Committed 18 Dec 2024 03:59PM UTC coverage: 87.965% (+0.007%) from 87.958%

Build # 12396681031

Build Type

push

github

Committed by

web-flow

Commit Message

[native_assets_cli] Nest `CodeConfig` OS-specific config (#1824)

Dart and Flutter have been passing the minimum OS SDK versions for a while (in non-dry-run), which means we can mark these fields non-optional if the target OS is used.

This PR changes the `CodeConfig` to nest the OS versions (and iOS target SDK: device or simulator) to be nested under the OS and required.

Other side effects of this PR:

* Many unit tests where missing these (now) mandatory fields
* `native_toolchain_c` can no longer test without the minimum OS versions, which changed the iOS test `otool` output.

Addressing:

* https://github.com/dart-lang/native/issues/1738#issuecomment-2535921222

Run Details

46 of 53 new or added lines in 3 files covered. (86.79%)

12133 of 13793 relevant lines covered (87.96%)

33.83 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	82.65	0.0%	pkgs/native_assets_cli/lib/src/code_assets/validation.dart
6	79.27	6.72%	pkgs/native_assets_cli/lib/src/code_assets/config.dart

Subprojects

ID	Flag name	Job ID	Ran	Files	Coverage
6	native_toolchain_c_windows	12396681031.6	18 Dec 2024 04:03PM UTC	26	78.69	GitHub Action Run
7	native_assets_builder_ubuntu	12396681031.7	18 Dec 2024 04:04PM UTC	11	90.37	GitHub Action Run
8	native_assets_builder_windows	12396681031.8	18 Dec 2024 04:06PM UTC	11	90.37	GitHub Action Run
9	native_toolchain_c_macos	12396681031.9	18 Dec 2024 04:01PM UTC	26	69.6	GitHub Action Run
10	native_assets_cli_ubuntu	12396681031.10	18 Dec 2024 04:01PM UTC	29	76.61	GitHub Action Run
11	native_assets_builder_macos	12396681031.11	18 Dec 2024 04:06PM UTC	11	90.37	GitHub Action Run
12	native_assets_cli_macos	12396681031.12	18 Dec 2024 04:00PM UTC	29	76.61	GitHub Action Run
13	native_assets_cli_windows	12396681031.13	18 Dec 2024 04:01PM UTC	29	76.28	GitHub Action Run
14	native_toolchain_c_ubuntu	12396681031.14	18 Dec 2024 04:01PM UTC	26	74.37	GitHub Action Run
14	objective_c	12388687570.14	18 Dec 2024 08:02AM UTC	73	78.19	GitHub Action Run
2	ffigen	11849122173.2	15 Nov 2024 02:35AM UTC	72	91.46	GitHub Action Run
13	jnigen	12342848478.13	15 Dec 2024 10:44PM UTC	22	89.31	GitHub Action Run
14	jni	12342848478.14	15 Dec 2024 10:38PM UTC	30	70.77	GitHub Action Run
14	swift2objc	12362379980.14	16 Dec 2024 10:24PM UTC	40	87.07	GitHub Action Run

dart-lang / native / 12396681031
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Subprojects

Source Files on build 12396681031

dart-lang / native / 12396681031 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Subprojects

Source Files on build 12396681031

dart-lang / native / 12396681031
92%

README BADGES
x