• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

SwissDataScienceCenter / renku-data-services / 12373079746
86%

Build:
DEFAULT BRANCH: main
Ran 17 Dec 2024 12:40PM UTC
Jobs 2
Files 281
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Dec 2024 12:32PM UTC coverage: 86.558% (+0.2%) from 86.389%
12373079746

push

github

web-flow
feat!: add support for session secrets (#545)

Closes #509.

Details:
* Add support for session secret slots which describe files with secret contents to be mounted in sessions. Session secret slots exist at the project level and can be managed by users with at the WRITE permission on the project. Session secrets can be used by all users with the READ permission on the project.
* Add support for session secrets which connect a project's session secret slots to user secrets. Session secrets can be used by all users with the READ permission on the project.
* Add support for mounting user secrets in sessions according to the project's session secret slots.
* Add support for multiple names in `key_mapping` when creating a kubernetes secret. This allows the same user secret to be supplied more than once in sessions.
* Re-work user secrets to make them more usable in Renku 2.0.
    - Change the `name` field to be `default_filename`. This field is only meaningful in the context of Renku 1.0.
    - Add a new `name` field (which does not have constraints) to let users name their secrets, e.g. "AWS Secret Key ID for Project XYZ".
    - User secret objects now include back references to Session secret slots and Data connectors -> `session_secret_slot_ids` and `data_connector_ids` fields returned from the API.
    - The `UserSecretsRepo` class has been split into `LowLevelUserSecretsRepo` and `UserSecretsRepo`. `LowLevelUserSecretsRepo` is used internally, e.g. for key rotation  and `UserSecretsRepo` is used for the `UserSecretsBP` blueprint
* Add a new field secrets_mount_directory to projects, which allows user to configure where secrets are mounted in sessions.

---------

Co-authored-by: Tasko Olevski <olevski90@gmail.com>
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>

632 of 683 new or added lines in 27 files covered. (92.53%)

4 existing lines in 4 files now uncovered.

15132 of 17482 relevant lines covered (86.56%)

1.53 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
97.72
0.33% components/renku_data_services/project/blueprints.py
1
79.41
0.46% components/renku_data_services/secrets/core.py
2
95.16
-1.81% components/renku_data_services/project/core.py
2
94.59
-2.28% components/renku_data_services/secrets/orm.py
3
88.0
components/renku_data_services/migrations/versions/a59e60e0338f_update_user_secrets.py
5
92.68
-0.03% components/renku_data_services/secrets/db.py
7
61.96
-3.48% components/renku_data_services/notebooks/api/amalthea_patches/init_containers.py
9
94.08
0.0% components/renku_data_services/project/db.py
21
44.48
-2.73% components/renku_data_services/notebooks/blueprints.py

Uncovered Existing Lines

Lines Coverage ∆ File
1
98.36
-1.64% components/renku_data_services/base_api/misc.py
1
84.71
-0.64% components/renku_data_services/crc/models.py
1
44.48
-2.73% components/renku_data_services/notebooks/blueprints.py
1
79.41
0.46% components/renku_data_services/secrets/core.py
Jobs
ID Job ID Ran Files Coverage
1 run-main-tests - 12373079746.1 17 Dec 2024 12:45PM UTC 281
86.17
GitHub Action Run
2 run-schemathesis-tests - 12373079746.2 17 Dec 2024 12:40PM UTC 281
66.39
GitHub Action Run
Source Files on build 12373079746
  • Tree
  • List 281
  • Changed 37
  • Source Changed 25
  • Coverage Changed 34
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #12373079746
  • c8509e78 on github
  • Prev Build on main (#12292839067)
  • Next Build on main (#12411111951)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc