Ouranosinc / xclim / 12285082901

92%

Build Type

push

github

Committed by web-flow

Commit Message

Various typing and signature fixes (#2018)

### What kind of change does this PR introduce?

* Addresses a few typing errors.
* Fixes a few overwritten variables in doctests.
* Fixes the call signature of `hot_spell_max_magnitude` to remove `op`.
* Fixes the call signature of `mbcn_adjust` to precisely report that
DataArrays are expected and Dataset is returned.

### Does this PR introduce a breaking change?

Yes. `hot_spell_max_magnitude` previously accepted an `op` argument that
was unused in the algorithm. This has been removed.

### Other information:

There is much more work to be done, but many changes require significant
refactors. There's enough in the current release to justify stopping
here for now.

Run Details

14 of 23 new or added lines in 10 files covered. (60.87%)

2 existing lines in 2 files now uncovered.

9437 of 10513 relevant lines covered (89.77%)

7.6 hits per line