• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

agama-project / agama / 12238189331
68%

Build:
DEFAULT BRANCH: master
Ran 09 Dec 2024 02:56PM UTC
Jobs 2
Files 640
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 Dec 2024 02:54PM UTC coverage: 71.08% (+0.003%) from 71.077%
12238189331

push

github

web-flow
service: Workaround for error on s390x (#1822)

## Problem

As described at #1818, there seems to be a problem when installing at
s390x and starting with no available disks. See [this
comment](https://github.com/agama-project/agama/issues/1818#issuecomment-2527658289)
at the original issue.

After visiting the DASD section and activating+formatting a device, the
backend fails and the UI becomes barely usable.

The error is produced when checking `storage_manager.proposal` after
re-probing the system and trying an (unsuccessful) proposal.

## Solution

This pull request does not implement a real fix, but a workaround that
has proven to be useful in that case. It allowed the installation to
continue successfully at the reported scenario.

I tried to fix the real root of the issue, but I was unable to find out
why `storage_manager.proposal` was nil at that point.

But since we are rewriting the approach to the storage proposal, the
whole `ProposalStrategies::Guided` class is going to disappear so it
makes little sense to invest more time.

I will keep the original issue open and will create a Trello card to
track it, so we check whether the new implementation of the storage
proposal (still under development) is reliable in that situation.

## Testing

Verified with manual testing. Going further would be wasting resources
right now.

1 of 1 new or added line in 1 file covered. (100.0%)

17030 of 23959 relevant lines covered (71.08%)

35.95 hits per line

Subprojects
ID Flag name Job ID Ran Files Coverage
2 service 12238189331.2 09 Dec 2024 02:56PM UTC 516
89.33
GitHub Action Run
2 rust 12139160171.2 03 Dec 2024 12:09PM UTC 124
24.66
GitHub Action Run
Source Files on build 12238189331
  • Tree
  • List 640
  • Changed 34
  • Source Changed 15
  • Coverage Changed 12
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #12238189331
  • 6501805c on github
  • Prev Build on master (#12147913808)
  • Next Build on master (#12315132141)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc