agama-project / agama / 12238189331

68%

push

github

service: Workaround for error on s390x (#1822)

## Problem

As described at #1818, there seems to be a problem when installing at
s390x and starting with no available disks. See [this
comment](https://github.com/agama-project/agama/issues/1818#issuecomment-2527658289)
at the original issue.

After visiting the DASD section and activating+formatting a device, the
backend fails and the UI becomes barely usable.

The error is produced when checking `storage_manager.proposal` after
re-probing the system and trying an (unsuccessful) proposal.

## Solution

This pull request does not implement a real fix, but a workaround that
has proven to be useful in that case. It allowed the installation to
continue successfully at the reported scenario.

I tried to fix the real root of the issue, but I was unable to find out
why `storage_manager.proposal` was nil at that point.

But since we are rewriting the approach to the storage proposal, the
whole `ProposalStrategies::Guided` class is going to disappear so it
makes little sense to invest more time.

I will keep the original issue open and will create a Trello card to
track it, so we check whether the new implementation of the storage
proposal (still under development) is reliable in that situation.

## Testing

Verified with manual testing. Going further would be wasting resources
right now.

1 of 1 new or added line in 1 file covered. (100.0%)

17030 of 23959 relevant lines covered (71.08%)

35.95 hits per line