12218915667
83%

Ran 08 Dec 2024 05:42AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 06 Dec 2024 07:35PM UTC coverage: 85.369% (-0.03%) from 85.402%

Build # 12218915667

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Subject state consistency (#6226)

Subject state would not always remain consistent given a specific
pattern of message removals.

There were three bugs:
- `recalculateFirstForSubj` in memstore would do `startSeq+1`, but
filestore would always just start at `mb.first.seq`. These are now
consistent.
- `recalculateFirstForSubj` was not called when `ss.Msgs == 1`, which
could mean we had a stale `ss.FirstSeq` if it needed to be recalculated.
- If after recalculation it turns out `ss.FirstSeq` equals the message
we're trying to remove, we need to `recalculateFirstForSubj` again,
since `ss.Last` is also lazy and could be incorrect.

Apart from that, filestore and memstore are now both equivalent when it
comes to first updating per-subject state and then removing the message,
as well as `removeSeqPerSubject` and how it updates the subject state.


Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

68242 of 79938 relevant lines covered (85.37%)

1478767.69 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	12218915667.1	08 Dec 2024 05:42AM UTC	0	85.37	GitHub Action Run

Source Files on build 12218915667

Detailed source file information is not available for this build.

nats-io / nats-server / 12218915667
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12218915667

nats-io / nats-server / 12218915667 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12218915667

nats-io / nats-server / 12218915667
83%

README BADGES
x