babelfish-for-postgresql / babelfish_extensions / 12097089779
77%

DEFAULT BRANCH: BABEL_5_X_DEV
Ran
Jobs 1
Files 115
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 74.795%. Remained the same
12097089779

push

github

web-flow 
Fix timeoffset in case of non-default timezone (#3174)

Description
1. Issue

    When the default timezone is not UTC then the result shows incorrect timezone offset value with AT TIME ZONE property. This is due to the fact that the timezone offset which is calculated using input_expr_tmz which is text explicitly converted to TIMESTAMPTZ which takes into account the current session timezone setting which produces this timezone difference in the output.

2. Changes made to fix the issue

    We will now calculate the timezone offset with absolute value of timezone that is by subtracting the datetime value in current timezone with the value in UTC timezone.

# Previous output (incorrect)
1> Select convert(datetimeoffset,'2002-01-01 02:01:00.000 +00:00') AT TIME ZONE 'eastern standard time';
2> go
timezone                                     
---------------------------------------------
           2001-12-31 21:01:00.0000000 -05:00

(1 rows affected)
1> select set_config('timezone', 'Asia/Kolkata', false)
2> go
set_config                                                                                                                                                                                                                                                      
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Asia/Kolkata                                                                                                                                                                                                                                                    

(1 rows affected)
1> Select convert(datetimeoffset,'2002-01-01 02:01:00.000 +00:00') AT TIME ZONE 'eastern standard time';
2> go
timezone                        ... (continued)

46439 of 62088 relevant lines covered (74.8%)

158399.2 hits per line

Jobs
ID Job ID Ran Files Coverage
1 12097089779.1 115
74.8
 GitHub Action Run
Source Files on build 12097089779