shinghim / rust-bitcoin / 12022962139

84%

push

github

Merge rust-bitcoin/rust-bitcoin#3639: units: Add integration test of API surface

<a class=hub.com/shinghim/rust-bitcoin/commit/7b8369f381c3f3fc15ed536d5316e86e02914b4e">7b8369f38 units: Add integration test of API surface (Tobin C. Harding)

Pull request description:

  In an effort to check off items in the Rust API guidelines checklist (#3632) add an integration test file that tests:

  - The location of re-exports for various typical usage styles.
  - Regressions in the API surface (things being accidentally moved).
  - All public types implement Debug (C-DEBUG).
  - For all non-error types:
      - `Debug` representation is never empty (C-DEBUG-NONEMPTY)
  - For all error types:
      - Derive standard traits as defined by `rust-bitcoin` policy.
  - All data structures implement `serde` traits (C-SERDE).

  I used the `cargo check-api` script we have laying around from ages ago (#2986) to parse `units` and get a list of the public types.

ACKs for top commit:
  apoelstra:
    ACK 7b8369f381c3f3fc15ed536d5316e86e02914b4e; successfully ran local tests

Tree-SHA512: 6fa2a61f62a49e7aac405505805b4018aaa

20061 of 24294 relevant lines covered (82.58%)

17878.65 hits per line