shinghim / rust-bitcoin / 11819516981

84%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3601: Fix bug in witness stack getters

<a class=hub.com/shinghim/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/shinghim/rust-bitcoin/commit/1ed3fc9270c6e46f42f447bf1c63cfa64dafa5e8">1ed3fc927<a href="https://github.com/shinghim/rust-bitcoin/commit/38701213717045642abdd3b2f004be81f33887e4"> Add unit test for tapscript function (Tobin C. Harding)
<a class="double-link" href="https://github.com/shinghim/rust-bitcoin/commit/195615c14d2ee3632af54859bb403d6c622c95b7">195615c14</a> Fix bug in witness stack getters (Tobin C. Harding)

Pull request description:

  In #2646 we introduced a bug in the taproot witness stack getter functions, of which we have three:

  - `tapscript`
  - `taproot_control_block`
  - `taproot_annex`

  Each returns `Some` if a possible bytes slice is found (with no other guarantees).

  Use `taproot_annex` combined with getters from `primitives` to implement the other two getters. This simplifies the code and fixes the bug.

  Add an additional getter to `primitives` `Witness::third_from_last`.

  Fix: #3598

ACKs for top commit:
  sanket1729:
    ACK 1ed3fc9270c6e46f42f447bf1c63cfa64dafa5e8
  apoelstra:
    ACK 1ed3fc9270c6e46f42f447bf1c63cfa64dafa5e8; successfully ran local tests

Tree-SHA512: fdaa254a00fa486015427677332e62b9ec5

Run Details

35 of 37 new or added lines in 2 files covered. (94.59%)

165 existing lines in 7 files now uncovered.

19753 of 23952 relevant lines covered (82.47%)

18156.28 hits per line