benrr101 / node-taglib-sharp / 51049499

93%

Build Type

push

appveyor

Committed by web-flow

Commit Message

Fix MP3 VBR Headers (#113)

**Description**: This is basically a rewrite of the VBR header implementation for MP3 files. It offers a much more robust solution for determining duration of MP3s and best efforts at determining MP3 bitrates.

**Testing**: Brand new testing of the VBR headers and MPEG audio headers

---

* Code for reading VBR headers is waaaaay improved. Only thing remaining is taking into consideration encoder delays from sample count

* Incorporate encoder delay/padding from LAME headers

* Incorporate delay for VBRI headers

* Adding sample files

* Working on tests...

* 100% coverage of MpegAudioHeader

* Unit tests for VBRI headers

* Unit tests for VBR headers

* Updating MPEG header to prevent reserved bitrate/audio sample rates from being propagated

* Rollback "allow zero" changes, patch up the rest of the unit tests

* Removing properties tests from mp3 id3vx tests

* Fix MPEG audio stream detection
ALSO UNCOVER A HUGE BUG IN APE FILE INTEGRATION TESTS??? WTF

* Fixing a thing after merging develop

* Enabling one more test

Run Details

3251 of 4131 branches covered (78.7%)

Branch coverage included in aggregate %.

496 of 503 new or added lines in 11 files covered. (98.61%)

1 existing line in 1 file now uncovered.

26757 of 28290 relevant lines covered (94.58%)

471.56 hits per line