benrr101 / node-taglib-sharp / 51048355

93%

push

appveyor

Fix Ape Tag Bugs (#112)

**Description**: There's a bug in Ape integration tests - the temp file was being loaded as an mp3. I have no idea *why* the tests weren't failing, but anyways, upon fixing that issue, two Ape tests failed:
* WriteStandardPictures
  * Ape tag class wasn't limiting the size of the binary tags
    * Fixed by adding a parameter back to the subarray method that limits the size of the binary data
  * Standard picture tests were assuming mimetype would be written correctly for all formats
    * Fixed by allowing application/octet-stream as a valid test mimetype for the non-picture picture
* WriteExtendedTags
  * Combined tag class was erroneously accepting NaN from empty tags as valid values for replaygain properties
    * Fixed by changing the logic for choosing which tag to use for combined tag reading


* Fixing bug with ape tag integration test

* Fix a bug in combined tag that broke probably more things than expected

3255 of 4138 branches covered (78.66%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

26810 of 28342 relevant lines covered (94.59%)

423.27 hits per line