noironetworks / aci-containers / 10121

70%

master: 69%

Build Type

Pull #1433

travis-pro

Committed by smshareef

Commit Message

Fixes related to cluster wide SNAT policy

1. When a cluster wide SNAT policy is present and service SNAT
   policy is created along with service, SNAT files was not getting
   deleted when service SNAT policy or the service is deleted.

   Root cause: When a SNAT policy name is deleted from the NodeInfo CR,
   that information was not updated in SnatGlobalInfo CR

   Fix: Added fix to remove the SNAT entries that are not present in the
   NodeInfo from SnatGlobalInfo cache and thereby from the
   SnatGlobalInfo CR

2. When a cluster wide SNAT policy is present and a service is deleted,
   the SNAT uuid of cluster wide SNAT policy was getting removed from EP
   file of the service endpoints.

   Root cause: When a service is deleted, all the SNAT policies
   applicable to the service endpoints were deleted from SnatLocalInfo

   Fix: When service is deleted, only service SNAT policy is removed
   from the SnatLocalInfo

(cherry picked from commit 172de9677)
(cherry picked from commit 27699e40e)

Pull Request Pull Request #1433: Fixes related to cluster wide SNAT policy

Run Details

24 of 33 new or added lines in 2 files covered. (72.73%)

6 existing lines in 2 files now uncovered.

11299 of 16048 relevant lines covered (70.41%)

0.8 hits per line