Unleash / unleash / 11949157379

88%

master: 91%

push

github

fix: count lifecycle more accurately (#8816)

This PR fixes three things that were wrong with the lifecycle summary
count query:

1. When counting the number of flags in each stage, it does not take
into account whether a flag has moved out of that stage. So if you have
a flag that's gone through initial -> pre-live -> live, it'll be counted
for each one of those steps, not just the last one.

2. Some flags that have been archived don't have the corresponding
archived state row in the db. This causes them to count towards their
other recorded lifecycle stages, even when they shouldn't. This is
related to the previous one, but slightly different. Cross-reference the
features table's archived_at to make sure it hasn't been archived

3. The archived number should probably be all flags ever archived in the
project, regardless of whether they were archived before or after
feature lifecycles. So we should check the feature table's archived_at
flag for the count there instead

2778 of 3619 branches covered (76.76%)

6 of 6 new or added lines in 1 file covered. (100.0%)

14353 of 16375 relevant lines covered (87.65%)

707.69 hits per line