kobotoolbox / kpi / 11940403833

82%

master: 76%

push

github

chore: remove in-browser mocha test environment (#5269)

### 👀 Preview steps

1. rebuild/run this branch as usual
1. 🟢 note that http://kf.kobo.local/browser_tests/ now redirects to
`/#/projects/home`

### 💭 Notes

Cleanup after:

- #5264

Removes the rest of `mocha` in favor of jest runner: remove
`"test-mocha-autobuild"` script, the defunct `/browser_tests/` page and
its dependencies.

#### Removals

- 🧪 **Remove `test-mocha-autobuild` and test/index.html**
> [#2890](https://github.com/kobotoolbox/kpi/issues/2890): In the past
would load the mocha test suite and would provide an easy way to debug
broken tests and write new ones.
  
I've used the browser-based runner and was hesitant to remove it in
[#5264](https://github.com/kobotoolbox/kpi/pull/5264). But, as others
pointed out, we don't need to keep mocha around for this, as Jest
supports both use cases.
  
1. For regular test-writing or debugging, like all the fixes in
[#5264](https://github.com/kobotoolbox/kpi/pull/5264), or re-running
tests on change, **use Jest's [watch
mode](https://jestjs.io/docs/cli#--watch)** (`npm run test-watch`). It's
pretty good.
2. For fixes like
[`8d5a6ff0`](https://github.com/kobotoolbox/kpi/commit/8d5a6ff05#diff-3cbd670915d20a7f56e4524cc3235c7ae),
where the console output might be misleading, or anywhere a step
debugger or REPL could save time, see [Jest's troubleshooting
page](https://jestjs.io/docs/troubleshooting#tests-are-failing-and-you-dont-know-why)
with steps to **connect Node/Chrome Devtools**.

- 🌐 **Remove
[`/browser_tests/`](https://kf.kobotoolbox.org/browser_tests)**
> [#2913](https://github.com/kobotoolbox/kpi/pull/2913) The tests could
also be used to help identify if a user experiences a bug specific to
their browser
  
Deploying a test runner to a production server in order to help with bug
triage is a nice idea. On the other hand, no one se... (continued)

5630 of 9091 branches covered (61.93%)

21545 of 26938 relevant lines covered (79.98%)

0.8 hits per line