Unleash / unleash / 11894164702

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Remove `idNumberMiddleware` and change to use `parameters` in `validPath` method instead (#8734)

## About the changes

- Remove `idNumberMiddleware` method and change to use `parameters`
field in `openApiService.validPath` method for the flexibility.
- Remove unnecessary `Number` type converting method and change them to
use `<{id: number}>` to specify the type.

### Reference

The changed response looks like the one below.

```JSON
{
   "id":"8174a692-7427-4d35-b7b9-6543b9d3db6e",
   "name":"BadDataError",
   "message":"Request validation failed: your request body or params contain invalid data. Refer to the `details` list for more information.",
   "details":[
      {
         "message":"The `/params/id` property must be integer. You sent undefined.",
         "path":"/params/id"
      }
   ]
}
```

I think it might be better to customize the error response, especially
`"You sent undefined."`, on another pull request if this one is
accepted. I prefer to separate jobs to divide the context and believe
that it helps reviewer easier to understand.

Run Details

2761 of 3592 branches covered (76.87%)

7 of 8 new or added lines in 2 files covered. (87.5%)

7 existing lines in 3 files now uncovered.

14291 of 16309 relevant lines covered (87.63%)

708.73 hits per line