skeema / skeema / 11827732160

92%

Build Type

push

github

Committed by evanelias

Commit Message

docker: more improvements and fixes for Percona Server images

This commit makes several minor changes to handling of Docker images and
containers for Percona Server flavors. These changes affect workspace=docker
when using flavor="percona:...", as well as Skeema's integration test
suites.

* tmpfs apparently is not supported by any Percona Server image, regardless of
  image source or architecture. A tmpfs mount is no longer attempted for
  Percona Server images with docker-cleanup=destroy, or in integration tests.

* When obtaining a Docker image for Percona Server 8.0 on Intel/AMD, the image
  is now fetched from percona/percona-server instead of _/percona. The latter
  appears to have been abandoned by its maintainers, as it lacks the two most
  recent 8.0.x releases. (On arm64 systems, percona/percona-server was already
  used by Skeema, since _/percona only ever had amd64 images.)

* Whenever the database server's flavor does not match the configured flavor
  option in the .skeema file, a warning is emitted; this check previously
  considered the vendor, variant (e.g. Percona Server or Aurora), major and
  minor version. This logic has now been tweaked to ignore differences in
  variant. This allows Percona Server users to specify a MySQL flavor manually
  if they wish to use a tmpfs mount with docker-cleanup=destroy. (This will
  work properly as long as column compression is not used, as that is
  currently the only Percona Server-specific feature affecting DDL syntax.)

* On arm64, when requesting the latest Percona Server 8.0 or 8.4 image, the
  patch release number is now omitted from the generated container name, to
  match behavior for other images/situations.

* On arm64, when running integration tests against Percona Server 8.x, use of
  e.g. SKEEMA_TEST_IMAGES=percona:8.0 is now permitted without requiring a
  specific patch release number.

Coverage Stats

52 of 62 new or added lines in 5 files covered. (83.87%)

3 existing lines in 3 files now uncovered.

10087 of 10825 relevant lines covered (93.18%)

1.11 hits per line