rust-bitcoin / rust-bitcoin / 11809194004

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3605: Mark function as const

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/1db4b723dc59568c14c76598e7c63c58651ed1cd">1db4b723d Mark function as const (yancy)

Pull request description:

  We discussed marking from_vb as const here: https://github.com/rust-bitcoin/rust-bitcoin/issues/3602

  However, from what I can tell, map() isn't const and I don't see a tracking issue for changing it.  Also, the question mark operator isn't available in const context either, although there is a tracking issue for that: https://github.com/rust-lang/rust/issues/74935.  It will be a long while before that makes it into this projects MSRV if/when it lands.

  There are some other functions in this module that could use the same re-write to make them const as well it looks like.

ACKs for top commit:
  tcharding:
    ACK 1db4b723dc59568c14c76598e7c63c58651ed1cd
  apoelstra:
    ACK 1db4b723dc59568c14c76598e7c63c58651ed1cd; successfully ran local tests

Tree-SHA512: 62b612791b9fd35839ef87d2f7840e9f77c

5 of 5 new or added lines in 1 file covered. (100.0%)

19738 of 23937 relevant lines covered (82.46%)

18111.81 hits per line