rust-bitcoin / rust-bitcoin / 11808075229

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3604: Add constructor to `FeeRate`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/b96501981ffef1d32c839cd44861736ce3683964">b96501981<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/708522394bbc6018b064b9ff76c3f3497fd33a42"> feat(units): add kvb constructor to `FeeRate` (Rob N)

Pull request description:

  This is partially to check my understanding. I did poorly in physics class as part of my misunderstanding of unit conversions.

  The `feefilter` message expresses the fee as satoshis per 1,000 vbyte, see the [p2p handling](https://github.com/bitcoin/bitcoin/blob/<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1dda1892b6bcc3d4f9678960cc9e9920f491e87e">1dda1892b</a>/src/net_processing.cpp#L5331) which calls [this function](https://github.com/bitcoin/bitcoin/blob/master/src/policy/feerate.h#L63) on the mempool. I presume all that needs to happen to express this in `kwu` is to divide by 4, but ideally a `FeeRate` may be constructed directly from a `feefilter` message using a constructor.

  My conversion is (sat / kvb * kvb / 4 kwu)

ACKs for top commit:
  sanket1729:
    ACK b96501981ffef1d32c839cd44861736ce3683964.
  apoelstra:
    ACK b96501981ffef1d32c839cd44861736ce3683964; successfully ran local tests
  tcharding:
    ACK b96501981ffef1d32c839cd44861736ce3683964

Tree-SHA512: 5aec75d257ec776912d6338958e0c54df0f

0 of 1 new or added line in 1 file covered. (0.0%)

19735 of 23934 relevant lines covered (82.46%)

18168.08 hits per line