11753399776
85%

Ran 09 Nov 2024 05:41AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 09 Nov 2024 02:39AM UTC coverage: 85.329% (-0.1%) from 85.43%

Build # 11753399776

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Ghost consumers during meta recovery (#6092)

During meta recovery `ru.updateConsumers` and `ru.removeConsumers` would
not be properly cleared since the move from
`map[string]*consumerAssignment` to
`map[string]map[string]*consumerAssignment`. Which meant that consumers
that needed to be removed were both in `ru.removeConsumers` and left in
`ru.updateConsumers`. Resulting in a ghost consumer.

Also don't clear recovering state while we still have items to process
as part of recovery.

De-flakes `TestJetStreamClusterLostConsumers`, and makes
`TestJetStreamClusterConsumerLeak` more reliable by re-introducing the
`ca.pending` flag. Since the consumer leader responds for consumer
creation, but meta leader responds for consumer deletion, so need to
have the consumer assignment available so meta leader can respond
successfully.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

---------

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

67808 of 79467 relevant lines covered (85.33%)

992856.0 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	72.46	-0.45%	src/github.com/nats-io/nats-server/server/avl/seqset.go
2	93.24	0.0%	src/github.com/nats-io/nats-server/server/route.go
2	82.95	0.0%	src/github.com/nats-io/nats-server/server/jetstream.go
3	90.37	-0.04%	src/github.com/nats-io/nats-server/server/leafnode.go
5	80.94	0.07%	src/github.com/nats-io/nats-server/server/opts.go
8	94.82	0.02%	src/github.com/nats-io/nats-server/server/client.go
22	84.36	-0.44%	src/github.com/nats-io/nats-server/server/stream.go
25	83.82	-0.34%	src/github.com/nats-io/nats-server/server/raft.go
29	73.19	-0.9%	src/github.com/nats-io/nats-server/server/store.go
65	87.65	-0.18%	src/github.com/nats-io/nats-server/server/consumer.go
186	84.39	-2.96%	src/github.com/nats-io/nats-server/server/memstore.go
817	83.36	-0.93%	src/github.com/nats-io/nats-server/server/filestore.go
926	80.48	0.79%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	11753399776.1	09 Nov 2024 05:41AM UTC	57	85.33	GitHub Action Run

nats-io / nats-server / 11753399776
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11753399776

nats-io / nats-server / 11753399776 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11753399776

nats-io / nats-server / 11753399776
85%

README BADGES
x