kobotoolbox / kpi / 11674136045

81%

master: 76%

push

github

feat: Enable support for XLSForm `name` setting (#5137)

## Checklist

1. [x] If you've added code that should be tested, add tests
2. [ ] If you've changed APIs, update (or create!) the documentation
3. [x] Ensure the tests pass
4. [x] Run `./python-format.sh` to make sure that your code lints and
that you've followed [our coding
style](https://github.com/kobotoolbox/kpi/blob/main/CONTRIBUTING.md)
5. [x] Write a title and, if necessary, a description of your work
suitable for publishing in our [release
notes](https://community.kobotoolbox.org/tag/release-notes)
6. [x] Mention any related issues in this repository (as #ISSUE) and in
other repositories (as kobotoolbox/other#ISSUE)
7. [x] Open an issue in the
[docs](https://github.com/kobotoolbox/docs/issues/new) if there are
UI/UX changes

## Description

This is an advanced feature for unusual cases where it's necessary to
[override the root XML node
name](https://xlsform.org/en/#specify-xforms-root-node-name) used in
submissions. This may be used for an upcoming feature to allow
customizable confirmation messages in Enketo.

## Notes

- Implemented logic to check and set the name attribute from XLSForms in
the survey object.
- The existing behavior where name was not utilized has been modified to
honor the name setting, defaulting to the id_string if name is not
provided or is invalid.

## Related issues

Part of #5112

---------

Co-authored-by: John N. Milner <john@tmoj.net>

5406 of 8786 branches covered (61.53%)

5 of 5 new or added lines in 2 files covered. (100.0%)

20771 of 26152 relevant lines covered (79.42%)

0.79 hits per line