11658207804
84%

Ran 04 Nov 2024 05:41AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 01 Nov 2024 03:19PM UTC coverage: 85.426% (-0.009%) from 85.435%

Build # 11658207804

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Handle recreating file-based stream to be memory on meta recovery (#6069)

For the following scenario:
1. create file-based R3 stream
2. delete stream
3. create memory-based R3 stream
4. add a consumer

The call to `js.processStreamAssignment(sa)` even while we're recovering
would mean that on meta recovery we'd first create the file-based
stream, then create the memory-based stream and fail to do so since we
can't change storage types. Which then leaves us stranded with 2 nodes
having a memory-based stream, and that one node with a file-based
stream.

This change proposes to have the stream additions be consistent with the
other collecting of state into `ru *recoveryUpdates` before applying,
and waiting until recovery is finished to do so.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Co-authored-by: Neil Twigg <neil@nats.io>

Run Details

67566 of 79093 relevant lines covered (85.43%)

923785.8 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	72.46	0.0%	src/github.com/nats-io/nats-server/server/avl/seqset.go
2	95.03	0.4%	src/github.com/nats-io/nats-server/server/client.go
2	80.94	0.0%	src/github.com/nats-io/nats-server/server/opts.go
3	86.12	-0.15%	src/github.com/nats-io/nats-server/server/events.go
7	84.47	0.28%	src/github.com/nats-io/nats-server/server/stream.go
12	73.11	-0.2%	src/github.com/nats-io/nats-server/server/jetstream_api.go
16	87.37	-0.33%	src/github.com/nats-io/nats-server/server/consumer.go
16	84.24	-0.19%	src/github.com/nats-io/nats-server/server/filestore.go
30	83.34	-0.5%	src/github.com/nats-io/nats-server/server/raft.go
52	80.09	-0.25%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	11658207804.1	04 Nov 2024 05:41AM UTC	57	85.43	GitHub Action Run

nats-io / nats-server / 11658207804
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11658207804

nats-io / nats-server / 11658207804 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11658207804

nats-io / nats-server / 11658207804
84%

README BADGES
x