11639970079
84%

Ran 02 Nov 2024 05:41AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 01 Nov 2024 03:19PM UTC coverage: 85.435% (+0.07%) from 85.362%

Build # 11639970079

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Handle recreating file-based stream to be memory on meta recovery (#6069)

For the following scenario:
1. create file-based R3 stream
2. delete stream
3. create memory-based R3 stream
4. add a consumer

The call to `js.processStreamAssignment(sa)` even while we're recovering
would mean that on meta recovery we'd first create the file-based
stream, then create the memory-based stream and fail to do so since we
can't change storage types. Which then leaves us stranded with 2 nodes
having a memory-based stream, and that one node with a file-based
stream.

This change proposes to have the stream additions be consistent with the
other collecting of state into `ru *recoveryUpdates` before applying,
and waiting until recovery is finished to do so.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Co-authored-by: Neil Twigg <neil@nats.io>

Run Details

67573 of 79093 relevant lines covered (85.43%)

1139567.8 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	98.26	-1.74%	src/github.com/nats-io/nats-server/server/jetstream_versioning.go
2	87.2	-0.14%	src/github.com/nats-io/nats-server/server/memstore.go
3	86.41	0.15%	src/github.com/nats-io/nats-server/server/accounts.go
3	93.45	0.26%	src/github.com/nats-io/nats-server/server/route.go
5	86.02	-0.25%	src/github.com/nats-io/nats-server/server/events.go
5	73.08	0.38%	src/github.com/nats-io/nats-server/server/jetstream_api.go
6	84.73	0.44%	src/github.com/nats-io/nats-server/server/stream.go
8	84.3	0.07%	src/github.com/nats-io/nats-server/server/filestore.go
8	80.83	-0.04%	src/github.com/nats-io/nats-server/server/opts.go
13	94.61	-0.26%	src/github.com/nats-io/nats-server/server/client.go
18	87.63	0.16%	src/github.com/nats-io/nats-server/server/consumer.go
24	83.71	0.13%	src/github.com/nats-io/nats-server/server/raft.go
1102	79.86	-0.07%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	11639970079.1	02 Nov 2024 05:41AM UTC	57	85.43	GitHub Action Run

nats-io / nats-server / 11639970079
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11639970079

nats-io / nats-server / 11639970079 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11639970079

nats-io / nats-server / 11639970079
84%

README BADGES
x