• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

nats-io / nats-server / 11639970079
83%

Build:
DEFAULT BRANCH: main
Ran 02 Nov 2024 05:41AM UTC
Jobs 1
Files 57
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

01 Nov 2024 03:19PM UTC coverage: 85.435% (+0.07%) from 85.362%
11639970079

push

github

web-flow
[FIXED] Handle recreating file-based stream to be memory on meta recovery (#6069)

For the following scenario:
1. create file-based R3 stream
2. delete stream
3. create memory-based R3 stream
4. add a consumer

The call to `js.processStreamAssignment(sa)` even while we're recovering
would mean that on meta recovery we'd first create the file-based
stream, then create the memory-based stream and fail to do so since we
can't change storage types. Which then leaves us stranded with 2 nodes
having a memory-based stream, and that one node with a file-based
stream.

This change proposes to have the stream additions be consistent with the
other collecting of state into `ru *recoveryUpdates` before applying,
and waiting until recovery is finished to do so.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Co-authored-by: Neil Twigg <neil@nats.io>

67573 of 79093 relevant lines covered (85.43%)

1139567.8 hits per line

Jobs
ID Job ID Ran Files Coverage
1 11639970079.1 02 Nov 2024 05:41AM UTC 0
85.43
GitHub Action Run
Source Files on build 11639970079
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #11639970079
  • f981ac34 on github
  • Prev Build on main (#11624442986)
  • Next Build on main (#11648553118)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc