rust-bitcoin / rust-bitcoin / 11617695868

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3533: base58: Close all errors

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/c92290278eaa4b4f062928c6bc6c2984e1ab7ba6">c92290278 base58: Close all errors (Tobin C. Harding)

Pull request description:

  Currently we have a bunch of public errors in the `base58` crate. Only two are returned by public functions `decode()` and `decode_check()` (`Error` and `InvalidCharacterError` respectively).

  - Close the two public errors by adding private inner errors.
  - Add getters on the public errors to get the error data.
  - Make all other errors private.
  - Call `impl_from_infallible` for _all_ error types.

  Done as part of #3261

ACKs for top commit:
  apoelstra:
    ACK c92290278eaa4b4f062928c6bc6c2984e1ab7ba6; successfully ran local tests

Tree-SHA512: e2ecef896252c76ead7d607ac3ee01031ab

4 of 26 new or added lines in 2 files covered. (15.38%)

19738 of 23914 relevant lines covered (82.54%)

18165.33 hits per line