rust-bitcoin / rust-bitcoin / 11615767172

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3541: Re-organise the `amount` module

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/10ff979fbd76232ab28127600b7515bcf86467b9">10ff979fb<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b7fc0916611109e5e393d0af242491cf4ae71255"> amount: Move arbitrary impl (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d4d931160397830ca15fe2ca58a26a5bacf7f435">d4d931160</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b7fc0916611109e5e393d0af242491cf4ae71255"> amount: Move SignedAmount to private signed module (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0fc0e8760b87f02627c0524a3af1638844d9021e">0fc0e8760</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b7fc0916611109e5e393d0af242491cf4ae71255"> docs: Remove link from self (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/13f9fd1b77fb4a58c4d1b36a4ebc445f047c2659">13f9fd1b7</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b7fc0916611109e5e393d0af242491cf4ae71255"> amount: Move Amount to private unsigned module (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2d4c0fa6c11fc002f2f17fee58a53da79d93ee38">2d4c0fa6c</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b7fc0916611109e5e393d0af242491cf4ae71255"> amount: Format serde file (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/df962673421280ee38492638fa3daf9e75e035c3">df9626734</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b7fc0916611109e5e393d0af242491cf4ae71255"> amount: Move serde code to submodule (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/87c9a3fd11f8e913915be8e4ddfb65124bbf6212">87c9a3fd1</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b7fc0916611109e5e393d0af242491cf4ae71255"> amount: Format tests file (Tobin C. Harding)
e0bc68042 amount: Move test code to submodule (Tobin C. Harding)
7e1269704 tests: Use from_sat (Tobin C. Harding)
cd5d1aba2 amount: Format verification file (Tobin C. Harding)
01f907b7a amount: Move verification code to submodule (Tobin C. Harding)
5ce827c5e amount: Move error code to submodule (Tobin C. Harding)
abc54d034 Make amount module a directory (Tobin C. Harding)
851e4111e Run the formatter (Tobin C. Harding)

Pull request description:

  This is the first 14 patches from #3539 in case that on is too ambitious. If that one gets NACK'ed then this can close too.

  I really really don't want to rebase this so I"m putting it up in case any of the last 5 patches from #3539 are contentious. if #3539 can go in as is then we can close this one.

ACKs for top commit:
  apoelstra:
    ACK 10ff979fbd76232ab28127600b7515bcf86467b9; successfully ran local tests; nice! All straightforward moves etc. Will one-ACK merge

Tree-SHA512: 8ebfac3093966cae3fe72f67ec7cb8... (continued)

1107 of 1290 new or added lines in 6 files covered. (85.81%)

19737 of 23900 relevant lines covered (82.58%)

18208.42 hits per line