Ouranosinc / xclim / 11613924792

92%

push

github

Fix injection of added parameters (#1981)

### What kind of change does this PR introduce?

The issue was that a YAML definition of an indicator was not able to
inject (set) the `indexer` parameter on indicators that inherited from
`IndexingIndicator` (i.e. indicators that rely on a class-level
implementation of the indexing, instead of compute-level one).

This reorganizes how these class-added arguments are handled. It also
renames them "added" arguments instead of "injected" to clear the
confusion. "injection" now only means an indicator argument that is set
when creating a derived indicator (that what most YAML definitions do).
"added" is an argument that is not in the compute function, but added by
the class.

The example YAML is modified and a test is added using this
modification.

### Does this PR introduce a breaking change?
No.

The feature was not really documented and now it works instead of not.

5 of 5 new or added lines in 1 file covered. (100.0%)

9375 of 10487 relevant lines covered (89.4%)

7.55 hits per line