multipath-tcp / mptcpd / 11532288255

67%

push

github

Some clean-ups (#305)

* all: remove trailing whitespaces

These trailing whitespaces are useless characters. Many text editors
remove them automatically, and Git also complains about them.

Best to remove them to avoid unwanted changes, and warnings.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* include: add missing std include

When checking header files individually, some of them didn't include
stdbool.h ('bool' type) or stdint.h (uint32_t type).

Add the missing headers to have all these header files self-contained:
they can be compiled alone with analytic tools.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* c: remove unused headers

'clangd' reported a few unused headers. Best to remove them then.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* tests: fix strict-prototypes warning

clangd reported this issue:

  A function declaration without a prototype is deprecated in all versions of C.

We can simply adding 'void', we don't need any arguments there.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* git: ignore compile_commands.json file

It is useful to be used with clangd to enhance a text editor.

This file can be generated with bear, e.g.

  $ make clean
  $ bear --append -- make -j$(nproc) all check

While at it, also ignore .plist files: some CLang diagnostics files.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* git: ignore hidden files / directories

Similar to what is done in the Linux kernel: very likely, hidden files
and directories don't need to be tracked in git. There are exceptions
of course, like the '.github' directory, but we can always force their
inclusions with 'git add -f'.

This will at least ignore the '.cache' directory created by clangd.
Editors tend to create hidden directories and files too, so that would
cover that too.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
... (continued)

2 of 2 new or added lines in 1 file covered. (100.0%)

1409 of 2199 relevant lines covered (64.07%)

5.56 hits per line