multipath-tcp / mptcpd / 11532285882

67%

Build Type

push

github

Committed by web-flow

Commit Message

Support listener events (#304)

* events: add listener created/closed support

These events have been added to the upstream kernel a while ago, see
commit f8c9dfbd875b ("mptcp: add pm listener events") in the kernel.

To better explain why these events are useful, better to quote [1]:

  MPTCP for Linux, when not using the in-kernel PM, depends on the
  userspace PM to create extra listening sockets before announcing
  addresses and ports. Let's call these "PM listeners".

  With the existing MPTCP netlink events, a userspace PM can create PM
  listeners at startup time, or in response to an incoming connection.
  Creating sockets in response to connections is not optimal: ADD_ADDRs
  can't be sent until the sockets are created and listen()ed, and if all
  connections are closed then it may not be clear to the userspace PM
  daemon that PM listener sockets should be cleaned up.

  With the addition of MPTCP netlink events for listening socket close &
  create, PM listening sockets can be managed based on application
  activity.

These new events are then now handled by mptcpd, and plugins can be
notified via two new hooks:

 - listener_created(laddr, pm)
 - listener_closed(laddr, pm)

Link: https://github.com/multipath-tcp/mptcp_net-next/issues/313 [1]
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* plugins: sspi: add hooks for listener events

Just to serve as an example, similar to what is done for other events
like ADD_ADDR, RM_ADDR, and MP_PRIO.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* tests: lib: support new listener events

Just the structure to be able to test the new hooks.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* tests: plugins: add listener event support

Adding new hooks, checking the laddr value -- similar to what is done
when a new connection is created -- and incrementing the linked counter,
like the other hooks.

Signed-off-by: Ma... (continued)

Run Details

10 of 40 new or added lines in 2 files covered. (25.0%)

1 existing line in 1 file now uncovered.

1409 of 2199 relevant lines covered (64.07%)

5.56 hits per line