rust-bitcoin / rust-bitcoin / 11484634036
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 109
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.576% (-0.08%) from 82.653%
11484634036

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#3481: Decode an address string based on prefix

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/9c2ac46902ae2e6f2513ee125ea5c89953ac89a2">9c2ac4690<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2f40c30f738a40914a9bf24480a6270082aae19b"> Split up ParseError (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3d994f7bdb84cd3bb324fdb34947ed083464e35e">3d994f7bd</a> Decode an address string based on prefix (Jamil Lambert, PhD)

Pull request description:

  When a decoding error occurs for a bech32 address string the error is discarded and the same address string is attempted to be decoded as base58.  This then incorrectly returns a base58 error.

  Check the string prefix and decode as bech32 or base58 and return the relevant error.  If the prefix is unknown return an `UnknownHrpError`.

  Close #3044

ACKs for top commit:
  tcharding:
    ACK 9c2ac46902ae2e6f2513ee125ea5c89953ac89a2
  apoelstra:
    ACK 9c2ac46902ae2e6f2513ee125ea5c89953ac89a2; successfully ran local tests

Tree-SHA512: 40c943288efd8865c153b78c010b3151e8f

23 of 68 new or added lines in 2 files covered. (33.82%)

19715 of 23875 relevant lines covered (82.58%)

18299.46 hits per line

Jobs
ID Job ID Ran Files Coverage
1 11484634036.1 0
82.58
 GitHub Action Run
Source Files on build 11484634036
Detailed source file information is not available for this build.