rust-bitcoin / rust-bitcoin / 11482028070

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3486: Remove the I/O error variant when `consensus::deserialize`'ing

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/bbffa3db43802b30d23259c0372f16a877a0ef8b">bbffa3db4<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c7fbebbad822c060c560864bfe6a2dec2b872532"> Remove the IO error from DecodeError (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/713196be0d61313bd1873c4ec366efb4e43f6892">713196be0</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c7fbebbad822c060c560864bfe6a2dec2b872532"> Return DeserError from encode::deserialize (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/33566ac58c347f51bcb922e71a9a71dca7d916a0">33566ac58</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c7fbebbad822c060c560864bfe6a2dec2b872532"> Split encode::Error into two parts (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b04142c7459853e4e550224ad52d00f43709babb">b04142c74</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c7fbebbad822c060c560864bfe6a2dec2b872532"> Add encode::Error::MissingData variant (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5a42ef28507e365ef7c29096bfe794e063791979">5a42ef285</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c7fbebbad822c060c560864bfe6a2dec2b872532"> Do not manually map IO error (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/efd7f9f06cf9156517bef775545da713d982945a">efd7f9f06</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c7fbebbad822c060c560864bfe6a2dec2b872532"> Add error constructor parse_failed_error (Tobin C. Harding)
ebfef3f11 Return generic error as Some (Tobin C. Harding)
a6254212d Move consensus error code to submodule (Tobin C. Harding)

Pull request description:

  The `consensus::deserialize` and `consensus::deserilaize_partial` functions should not return an I/O error. Doing so causes various other error types to include an `io::Error` and the `io::Error` is an annoying type to work with.

  This PR is a bunch of steps, and it took me a good while with quite a bit of backtracking to get here. As such you may want to review the final state before looking at each patch.

  The `consensus` errors can be further cleaned up but I'd prefer not to spend more time on this unless it has some chance of merging.

ACKs for top commit:
  apoelstra:
    ACK bbffa3db43802b30d23259c0372f16a877a0ef8b; successfully ran local tests

Tree-SHA512: 522fdd296ba087a56ad4596943faa4ab186

Coverage Stats

71 of 169 new or added lines in 14 files covered. (42.01%)

2 existing lines in 2 files now uncovered.

19711 of 23848 relevant lines covered (82.65%)

18368.32 hits per line