tarantool / luajit / 11382361242

70%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Limit CSE for IR_CARG to fix loop optimizations.

Thanks to Peter Cawley.

(cherry picked from commit 3bdc6498c)

`IR_CALLXS` for the vararg function contains `IR_CARG(fptr, ctid)` as
the second operand. The `loop_emit_phi()` scans only the first operand
of the IR, so the second is not marked as PHI. In this case, when the IR
appears in both the invariant and variant parts of the loop, CSE may
remove it and thus lead to incorrect emitting results.

This patch tweaks the CSE rules to avoid CSE across the `IR_LOOP`.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#10199

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit b52fe9795)

Run Details

5673 of 6014 branches covered (94.33%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

19 existing lines in 4 files now uncovered.

21611 of 23357 relevant lines covered (92.52%)

869085.26 hits per line