tarantool / luajit / 11380100529

70%

tarantool/master: 93%

push

github

FFI: Fix 64 bit shift fold rules.

Thanks to Peter Cawley.

(cherry picked from commit 9e0437240)

For `IR_BSHR`, `IR_BROL`, `IR_BROR` during `kfold_int64arith()` the left
argument is truncated down to 32 bits, which leads to incorrect results
if the right argument is >= 2^32.

Also, `IR_BSAR` does an unsigned shift rather than a signed shift, but
since this case branch is unreachable, it is harmless for now.

This patch fixes all misbehaviours (including possible for `IR_BSAR`) to
preserve IR semantics.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#10199

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit f0bc08920)

5676 of 6013 branches covered (94.4%)

Branch coverage included in aggregate %.

21624 of 23353 relevant lines covered (92.6%)

895937.87 hits per line