zalando-incubator / kube-ingress-aws-controller / 11360484428

72%

push

github

aws: fail on ListCertificatesPages error (#725)

* aws: refactor ACM fake client to support returning errors

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>

* aws: fail on ListCertificatesPages error

`getACMCertificateSummaries` did not check `ListCertificatesPages` error
and returned empty `CertificateSummary` slice and no error
via `filterCertificatesByTag` if `filterTag` is configured.

Empty `CertificateSummary` results in empty `existingStackCertificateARNs`
for each `loadBalancer` model which triggered stack update:
```
level=info msg="Updating \"internet-facing\" stack for 0 certificates / 0 ingresses"
```
and then stack deletion on the next cycle:
```
level=info msg="Deleted orphaned stack \"kube-ingress-aws-controller-aws-XXX\""
```
due to empty certificate tags after previous update.

Follow up on #658

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>

---------

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>

21 of 21 new or added lines in 2 files covered. (100.0%)

3067 of 4202 relevant lines covered (72.99%)

11.26 hits per line