rust-bitcoin / rust-bitcoin / 11319004713

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3431: Move script types to `primitives`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d649c062385d28385d99c950ba30f67bff7670dd">d649c0623<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1b23d1c66cd5df0775deaf8a7c1bdde1fa310dd9"> Move script types to primitives (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ec4635904bf0533ce4f33b5594c5a7aa1f35c558">ec4635904</a> Inline bytes_to_asm_fmt into Script::Display impl (Tobin C. Harding)

Pull request description:

  First patch removes `bytes_to_asm_fmt` as requested by Kix here: https://github.com/rust-bitcoin/rust-bitcoin/pull/3194#discussion_r1756557768

  Second patch does the move. The move is minimal but there is quite a bit of code moved in `script/mod.rs` - I believe it is as minimal as required as well.

ACKs for top commit:
  apoelstra:
    ACK d649c062385d28385d99c950ba30f67bff7670dd successfully ran local tests

Tree-SHA512: 329a23948dd4860f85e32787d5e648d382c

94 of 223 new or added lines in 4 files covered. (42.15%)

19121 of 23165 relevant lines covered (82.54%)

18783.34 hits per line