rust-bitcoin / rust-bitcoin / 11317747020

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3456: feat: add sign fn for sign_message

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/c41a6e9b1bdc2f60b80519ab5b3fbb9f0eb46acb">c41a6e9b1 feat: add sign fn for sign_message (ChrisCho-H)

Pull request description:

  While it's not hard to create the signature using `secp256k1` modules with `signed_msg_hash`, it's much more convenient and safe to provide one-way function to generate signed signature(even without the understanding about the semantics of bitcoin message signing).

ACKs for top commit:
  apoelstra:
    ACK c41a6e9b1bdc2f60b80519ab5b3fbb9f0eb46acb successfully ran local tests
  tcharding:
    ACK c41a6e9b1bdc2f60b80519ab5b3fbb9f0eb46acb

Tree-SHA512: 84caea2752f79ac43dd008837096e9f1844

0 of 10 new or added lines in 1 file covered. (0.0%)

19123 of 23167 relevant lines covered (82.54%)

18775.59 hits per line