11174118948
85%

Ran 04 Oct 2024 05:37AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 03 Oct 2024 09:40PM UTC coverage: 85.234% (-0.05%) from 85.285%

Build # 11174118948

Build Type

push

github

Committed by

web-flow

Commit Message

(2.11) Don't send meta snapshot when becoming metaleader (#5700)

Antithesis testing has found that late or out-of-order delivery of these
snapshots, likely due to latency or thread pauses, can cause stream
assignments to be reverted which results in assets being deleted and
recreated. There may also be a race condition where the metalayer comes
up before network connectivity to all other nodes is fully established
so we may end up generating snapshots that don't include assets we don't
know about yet.

We will want to audit all uses of `SendSnapshot` as it somewhat breaks
the consistency model, especially now that we have fixed a significant
number of Raft bugs that `SendSnapshot` usage may have been papering
over.

Further Antithesis runs without this code run fine and have eliminated a
number of unexpected calls to `processStreamRemoval`.

We've also added a new unit test
`TestJetStreamClusterHardKillAfterStreamAdd` for a long-known issue, as
well as a couple tweaks to the ghost consumer tests to make them
reliable.

Signed-off-by: Neil Twigg <neil@nats.io>

---------

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Co-authored-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

66862 of 78445 relevant lines covered (85.23%)

1061294.65 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	50.83	0.41%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
2	94.71	-0.05%	src/github.com/nats-io/nats-server/server/client.go
2	66.67	-13.33%	src/github.com/nats-io/nats-server/server/jetstream_events.go
2	81.02	0.07%	src/github.com/nats-io/nats-server/server/opts.go
3	70.85	0.12%	src/github.com/nats-io/nats-server/server/jetstream_api.go
4	94.25	-0.08%	src/github.com/nats-io/nats-server/server/gateway.go
9	81.98	-0.32%	src/github.com/nats-io/nats-server/server/jetstream.go
9	83.76	0.01%	src/github.com/nats-io/nats-server/server/filestore.go
10	71.08	-3.01%	src/github.com/nats-io/nats-server/server/store.go
31	84.06	-0.55%	src/github.com/nats-io/nats-server/server/stream.go
66	84.17	-0.24%	src/github.com/nats-io/nats-server/server/raft.go
291	87.35	0.41%	src/github.com/nats-io/nats-server/server/consumer.go
808	79.82	-0.41%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	11174118948.1	04 Oct 2024 05:37AM UTC	57	85.23	GitHub Action Run

nats-io / nats-server / 11174118948
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11174118948

nats-io / nats-server / 11174118948 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11174118948

nats-io / nats-server / 11174118948
85%

README BADGES
x