• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

curationexperts / cypripedium / 75228403-6da3-4b76-8f5f-fe8e2adc69a7
94%
main: 98%

Build:
Build:
LAST BUILD BRANCH: hyrax_51
DEFAULT BRANCH: main
Ran 03 Oct 2024 09:46PM CUT
Jobs 2
Files 92
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

03 Oct 2024 09:43PM CUT coverage: 94.681% (-0.03%) from 94.713%
75228403-6da3-4b76-8f5f-fe8e2adc69a7

Pull #600

circleci

mark-dce
[MAINTENANCE] Refactor TarBag to remove global variables

**ISSUE**
A number of instance variables were used to pass values across
methods which made code linkages and dependencies difficult to
analyze.

**RESOLUTION**
This change removes all instance variables in the class and passes
required data as paramaters to the method calls. Where data from
the instance initialization is required, we've replaced references
to instance variables with corresponding attribute readers.

This change also adds more detailed testing of the TAR file that
gets created to confirm it has the esxpected content.
Pull Request #600: [MAINTENANCE] Refactor TarBag to remove global variables

17 of 17 new or added lines in 3 files covered. (100.0%)

44 existing lines in 6 files now uncovered.

1246 of 1316 relevant lines covered (94.68%)

13.0 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
91.67
-8.33% app/lib/contentdm/log.rb
2
50.0
-50.0% app/forms/collection_form_markdown.rb
3
55.56
-33.33% app/helpers/work_zips_helper.rb
4
84.0
-16.0% app/jobs/bag_job.rb
6
78.43
-11.76% app/controllers/creators_controller.rb
28
24.32
-75.68% app/models/work_zip.rb
Jobs
ID Job ID Ran Files Coverage
1 75228403-6da3-4b76-8f5f-fe8e2adc69a7.1 03 Oct 2024 09:46PM CUT 86
88.58
2 75228403-6da3-4b76-8f5f-fe8e2adc69a7.2 03 Oct 2024 09:48PM CUT 82
92.4
Source Files on build 75228403-6da3-4b76-8f5f-fe8e2adc69a7
  • Tree
  • List 92
  • Changed 34
  • Source Changed 0
  • Coverage Changed 2
Loading...
Coverage∆FileLinesRelevantCoveredMissedHits/Line
29.31
config/initializers/characterization_service.rb118 58 17 41 2.0
57.14
config/initializers/git_sha.rb28 14 8 6 2.0
76.92
...rers/hyrax/renderers/license_attribute_renderer.rb33 13 10 3 1.0
83.33
config/exception_middleware.rb16 6 5 1 18.0
88.89
app/helpers/work_zips_helper.rb16 9 8 1 3.0
90.0
app/renderers/hyrax/renderers/markdown_renderer.rb22 10 9 1 5.0
90.2
app/controllers/creators_controller.rb101 51 46 5 3.0
91.67
app/lib/rdf/markdown/literal.rb43 12 11 1 2.0
92.0
config/initializers/hyrax.rb225 25 23 2 2.0
94.74
app/lib/contentdm/import_file.rb55 19 18 1 7.0
Showing 1 to 10 of 92 entries
  • Previous
  • 1
  • 2
  • 3
  • 4
  • 5
  • …
  • 10
  • Next
  • ►
    97.95
    app/
  • ►
    85.29
    config/
  • Back to Repo
  • CircleCI Build #75228403...
  • Pull Request #600
  • PR Base - main (#F83CBB53...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc