31b67b34-c2ab-4e04-ac75-e6c8fe0d25af
94%
main: 98%

Ran 03 Oct 2024 09:40PM CUT

Jobs 4

Files 92

Run time 1min

Badge

Embed ▾

Committed 03 Oct 2024 09:33PM CUT coverage: 94.467% (-0.2%) from 94.713%

Build # 31b67b34-c2ab-4e04-ac75-e6c8fe0d25af

Build Type

Pull #600

circleci

Committed by

mark-dce

Commit Message

[MAINTENANCE] Refactor TarBag to remove global variables

**ISSUE**
A number of instance variables were used to pass values across
methods which made code linkages and dependencies difficult to
analyze.

**RESOLUTION**
This change removes all instance variables in the class and passes
required data as paramaters to the method calls. Where data from
the instance initialization is required, we've replaced references
to instance variables with corresponding attribute readers.

This change also adds more detailed testing of the TAR file that
gets created to confirm it has the esxpected content.

Pull Request Pull Request #600: [MAINTENANCE] Refactor TarBag to remove global variables

Run Details

14 of 17 new or added lines in 3 files covered. (82.35%)

27 existing lines in 11 files now uncovered.

1161 of 1229 relevant lines covered (94.47%)

15.11 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
3	37.5	-62.5%	app/lib/hyrax/zip_bag.rb

Uncovered Existing Lines

Lines	Coverage	∆	File
1	94.12	-5.88%	app/models/solr_document.rb
1	95.0	-2.5%	app/lib/hyrax/work_bag.rb
1	91.67	-8.33%	app/controllers/application_controller.rb
1	87.5	-12.5%	app/presenters/cypripedium_work_presenter.rb
2	37.5	-62.5%	app/lib/hyrax/zip_bag.rb
2	50.0	-50.0%	app/indexers/collection_indexer.rb
2	60.0	-40.0%	app/jobs/build_work_zip_job.rb
2	50.0	-50.0%	app/forms/collection_form_markdown.rb
4	84.0	-16.0%	app/jobs/bag_job.rb
5	28.57	-71.43%	app/helpers/markdown_helper.rb
6	78.43	-11.76%	app/controllers/creators_controller.rb

Jobs

ID	Job ID	Ran	Files	Coverage
1	31b67b34-c2ab-4e04-ac75-e6c8fe0d25af.1	03 Oct 2024 09:40PM CUT	77	87.86
2	31b67b34-c2ab-4e04-ac75-e6c8fe0d25af.2	03 Oct 2024 09:41PM CUT	76	87.49
3	31b67b34-c2ab-4e04-ac75-e6c8fe0d25af.3	03 Oct 2024 09:41PM CUT	79	83.77
4	31b67b34-c2ab-4e04-ac75-e6c8fe0d25af.4	03 Oct 2024 09:41PM CUT	65	88.61

Source Files on build 31b67b34-c2ab-4e04-ac75-e6c8fe0d25af

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
29.31	config/initializers/characterization_service.rb	118	58	17	41	4.0 + 2
57.14	config/initializers/git_sha.rb	28	14	8	6	4.0 + 2
76.92	...rers/hyrax/renderers/license_attribute_renderer.rb	33	13	10	3	1.0
83.33	config/exception_middleware.rb	16	6	5	1	21.0 + 3
88.89	app/helpers/work_zips_helper.rb	16	9	8	1	4.0 + 1.0
90.0	app/renderers/hyrax/renderers/markdown_renderer.rb	22	10	9	1	5.0
90.2	app/controllers/creators_controller.rb	101	51	46	5	4.0 + 1.0
91.67	app/lib/rdf/markdown/literal.rb	43	12	11	1	2.0
92.0	config/initializers/hyrax.rb	225	25	23	2	4.0 + 2
94.74	app/lib/contentdm/import_file.rb	55	19	18	1	7.0

97.95
app/
85.29
config/

curationexperts / cypripedium / 31b67b34-c2ab-4e04-ac75-e6c8fe0d25af
94%
main: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 31b67b34-c2ab-4e04-ac75-e6c8fe0d25af

curationexperts / cypripedium / 31b67b34-c2ab-4e04-ac75-e6c8fe0d25af 94% main: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 31b67b34-c2ab-4e04-ac75-e6c8fe0d25af

curationexperts / cypripedium / 31b67b34-c2ab-4e04-ac75-e6c8fe0d25af
94%
main: 98%

README BADGES
x